Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Make provider interface "stateless", SDK maintains provider state #844

Closed
9 tasks done
toddbaert opened this issue Mar 15, 2024 · 7 comments
Closed
9 tasks done
Assignees
Labels
contribfest A good issue for Contribfest KubeCon EU '24 v0.8.0

Comments

@toddbaert
Copy link
Member

toddbaert commented Mar 15, 2024

Stateless providers

Providers no longer maintain their own state: the state for each provider is maintained in the SDK automatically, and updated according to the success/failures of lifecycle methods (init/shutdown) or events emitted from providers spontaneously.

Similar work in C#: open-feature/dotnet-sdk#276

Tasks

@toddbaert toddbaert added v0.8.0 contribfest A good issue for Contribfest KubeCon EU '24 labels Mar 15, 2024
@toddbaert toddbaert added this to the Spec 0.8 Compliance milestone Mar 15, 2024
@toddbaert toddbaert added the help wanted Extra attention is needed label Apr 23, 2024
@gunishmatta
Copy link

Hi @toddbaert I would like to work on this.

@beeme1mr
Copy link
Member

beeme1mr commented May 8, 2024

Thanks, @gunishmatta, I've assigned you the issue. Please let us know if you have any questions!

@beeme1mr beeme1mr removed the help wanted Extra attention is needed label May 8, 2024
@toddbaert
Copy link
Member Author

@gunishmatta here's the implementation I did in the JS SDK: open-feature/js-sdk#795.

You can disregard the RECONCILING stuff - that only applies to client-side SDKs, which Java is not. The relevant stuff is all around the ProviderState. I used an internal wrapper class for this: https://github.com/open-feature/js-sdk/pull/795/files#diff-918e59c039e8a552dd77bdf93d9759acc86f58f677bf52e7a0990ff92683ef11R25, but take whatever approach you want.

@gunishmatta
Copy link

@toddbaert Thanks a lot for the guidance, you can expect my PR by end of this week.

Thanks
Gunish.

@toddbaert
Copy link
Member Author

Unassigned due to inactivity.

@toddbaert toddbaert added the help wanted Extra attention is needed label Sep 4, 2024
@chrfwow
Copy link
Contributor

chrfwow commented Sep 9, 2024

Hi @toddbaert I would like to work on this.

@toddbaert
Copy link
Member Author

I think this is done with #1096. I will confirm and close in the next couple days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest A good issue for Contribfest KubeCon EU '24 v0.8.0
Projects
None yet
Development

No branches or pull requests

4 participants