Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate THETA Keywords #122

Open
maxnoe opened this issue Jul 26, 2018 · 1 comment
Open

Disambiguate THETA Keywords #122

maxnoe opened this issue Jul 26, 2018 · 1 comment

Comments

@maxnoe
Copy link
Member

maxnoe commented Jul 26, 2018

Most (if not all) IACTs call the distance from the reconstructed gamma-ray position to the suspected source position theta, in wobble observation mode, background regions are used and this results in theta_off_* attributes.

The current version of the standard calls the distance of the reconstructed source position to the camera center THETA.

I think we should disambiguate this by adding subscripts like _FOV, _OBJ, _SRC, _ON, _OFF_*

@cdeil
Copy link
Member

cdeil commented Jul 26, 2018

In Gammapy we have this: https://github.com/gammapy/gammapy/pull/1295/files

For the spec, given that these formats are in use and implemented in several IRF exporters and science tools, there is a cost to changing axis names for consistency.

I'm putting this on v0.3 milestone, not for the v0.2 which we should try to finish up in the next days.

@cdeil cdeil added this to the 0.3 milestone Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants