-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSF Table documentation #174
Comments
Agree with mostly everything said here.
This is the only thing I disagree with. The standard here basically prescribes using proper spherical coordinates, which is the right thing to do. Experiments using other coordinate systems should convert to spherical when exporting IRFs in these formats. |
I also agree with @GernotMaier. Current specifications are full of jargons and we should definitely improve the wording. The best way to proceed is for @GernotMaier to create a pull-request with the proposed changes, so we can directly comment on them (this one should be easy, you already proposed good alternatives in your issue). If there is general consensus that the changes improve the wording use, then we just accept the pull request. |
No worries, I don't suggest to change anything in the coordinate definitions here. Just to be clearer through adding a half sentence or so. |
Proposal to clarify the meaning of the axes in the PSF histograms (see also issue open-gamma-ray-astro#174)
The documentation of the PSF tables is not entirely clear and could be clarified by better wording or using other expressions. There is jargon used, which makes it hard to understand. This issue is to discuss improvements.
This is the page: https://gamma-astro-data-formats.readthedocs.io/en/latest/irfs/full_enclosure/psf/psf_table/index.html#psf-table
For the FOV coordinates (https://gamma-astro-data-formats.readthedocs.io/en/latest/general/coordinates.html#coords-fov):
The text was updated successfully, but these errors were encountered: