Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flagd is not working for cart service #2095

Open
287611 opened this issue Feb 28, 2025 · 5 comments
Open

Flagd is not working for cart service #2095

287611 opened this issue Feb 28, 2025 · 5 comments
Labels
bug Something isn't working

Comments

@287611
Copy link

287611 commented Feb 28, 2025

We are using opentelemetry demo 2.0. Using helmchart to deploy opentelemetry demo application in kubernetes cluster

Enabled the flagd from feature page for cart service.

In the previous versions, we will get error metrics. But now error metrics are not generated if we enable flagd for cart service. Is there any dependent flagd that needs to be enabled along with cart service to see error metrics. We see problem only with error metrics, logs and traces seems to be fine

@287611 287611 added the bug Something isn't working label Feb 28, 2025
@puckpuck
Copy link
Contributor

puckpuck commented Mar 3, 2025

Hey @287611 I looked into this. I can see the error manifest itself in the checkout service when it makes a call to Empty the Cart (and the flag is turned on). I'm not sure if this flag generated errors elsewhere before, if it did please provide more details about that so we can check on any regressions.

Image

@287611
Copy link
Author

287611 commented Mar 3, 2025

Hi @puckpuck , thanks for the reply. Yes previously we were using version 0.33.8, it aws able to generate same kind of error. But the problem which we are facing now is error is reflecting only in traces and not in metrics. For example if we use metrics like traces_service_graph_request_failed_total , in the version 0.33.8 we were able to see the error in metrics also so that it is easy to correlate traces and metrics. Now this metrics traces_service_graph_request_failed_total is showing all fine with cart service which is a bit misleading

@julianocosta89
Copy link
Member

@287611 were you getting cart traces_service_graph_request_failed_total before?

I had a quick look and after adding servicegraph connector to the demo and enabling the cartFailure I got the following result:

Image Image

Checkout traces_service_graph_request_failed_total just started increasing after enabling the feature flag.

@287611
Copy link
Author

287611 commented Mar 3, 2025

Hi @puckpuck , traces_service_graph_request_failed_total was increasing for cartservice in the version 0.33.0 (helm chart). Now when this empty cart is not working, I feel the metrics shoud increase in cart and not in checkout service as empty cart is a feature of cart service and not checkout service. Even for me the traces_service_graph_request_failed_total metrics for other services but not for cart. Is there a way to make the metrics increase for cart when there is a problem in cart service ?

@287611
Copy link
Author

287611 commented Mar 3, 2025

This is opentelemetry 1.0 and the chart version is 0.33.8, it produces the correct result when the flagd is enabled in cart service

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants