Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency in zfsnode's zpool stats representation #621

Open
abhilashshetty04 opened this issue Feb 3, 2025 · 0 comments
Open

inconsistency in zfsnode's zpool stats representation #621

abhilashshetty04 opened this issue Feb 3, 2025 · 0 comments
Assignees

Comments

@abhilashshetty04
Copy link
Member

What steps did you take and what happened:

zfsnode resource capacity fields are represented in bytes and human-readable. Its bound to change also with every update on CR.

For example:

Here are 2 pools with no zvols on different nodes. Both zpools were created on 30G disk.

apiVersion: zfs.openebs.io/v1
kind: ZFSNode
metadata:
  creationTimestamp: "2025-01-30T06:53:24Z"
  generation: 2
  name: node-0-309787
  namespace: puls8
  ownerReferences:
  - apiVersion: v1
    controller: true
    kind: Node
    name: node-0-309787
    uid: d4ae440a-2fcc-487e-a056-8b1af6de985a
  resourceVersion: "39456"
  uid: d58cd02d-66ed-4921-ad44-a2ae39bc7557
pools:
- free: 29966204Ki
  name: zfspv-pool
  used: 99Ki
  uuid: "965947675669908193"
 
[nix-shell:~/mayarepo/openebs]# kubectl get zfsnodes node-1-309787 -n puls8 
apiVersion: zfs.openebs.io/v1
kind: ZFSNode
metadata:
  creationTimestamp: "2025-01-30T06:53:31Z"
  generation: 2
  name: node-1-309787
  namespace: puls8
  ownerReferences:
  - apiVersion: v1
    controller: true
    kind: Node
    name: node-1-309787
    uid: 75975c2a-14b7-4f19-ab5c-c22d32ae836c
  resourceVersion: "39478"
  uid: f6da8b1d-6439-480f-bebe-dc431cb88516
pools:
- free: "30685394432"
  name: zfspv-pool
  used: "99840"
  uuid: "10029612145612829144"

Here 1st pool is in human readable 2nd is in bytes. Now same 2 pools after getting 1 volumes each

 kubectl get zfsnode node-0-309787 node-1-309787 -oyaml
apiVersion: v1
items:
- apiVersion: zfs.openebs.io/v1
  kind: ZFSNode
  metadata:
    creationTimestamp: "2025-01-30T06:53:24Z"
    generation: 3
    name: node-0-309787
    namespace: puls8
    ownerReferences:
    - apiVersion: v1
      controller: true
      kind: Node
      name: node-0-309787
      uid: d4ae440a-2fcc-487e-a056-8b1af6de985a
    resourceVersion: "45216"
    uid: d58cd02d-66ed-4921-ad44-a2ae39bc7557
  pools:
  - free: "30685332992"
    name: zfspv-pool
    used: 156Ki
    uuid: "965947675669908193"
- apiVersion: zfs.openebs.io/v1
  kind: ZFSNode
  metadata:
    creationTimestamp: "2025-01-30T06:53:31Z"
    generation: 3
    name: node-1-309787
    namespace: puls8
    ownerReferences:
    - apiVersion: v1
      controller: true
      kind: Node
      name: node-1-309787
      uid: 75975c2a-14b7-4f19-ab5c-c22d32ae836c
    resourceVersion: "45238"
    uid: f6da8b1d-6439-480f-bebe-dc431cb88516
  pools:
  - free: 29966144Ki
    name: zfspv-pool
    used: "158208"
    uuid: "10029612145612829144"
kind: List
metadata:
  resourceVersion: ""

Here its mixed, each pool has 1 metric in human readable and other in bytes.

What did you expect to happen:
Everythin should be in bytes or human reable. should be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants