Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we standardize small molecule force field parameterization through SystemGenerator? #188

Open
jchodera opened this issue Feb 5, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jchodera
Copy link
Member

jchodera commented Feb 5, 2020

@SimonBoothroyd : We're approaching a new release of OpenMM that would allow us to use the new openforcefields.generators.SystemGenerator to generate parameterized systems that include small molecules using a common interface for SMIRNOFF, GAFF, and potentially future force field residue template generator plugins. Could this play some role in the future of property evaluator, allowing us to standardize the way we implement plugins to provide other small molecule force field types?

Because SystemGenerator currently uses the OpenMM ForceField class under the hood, it's a stop-gap solution until we can more fully switch to an all-openforcefield toolkit infrastructure, but the concept of isolating all external small molecule parameter assignment engines behind a single API that permits new force fields (like CGenFF, MMFF, and others) to be "plugged in" could be useful if we can somehow share the infrastructure among projects.

@SimonBoothroyd
Copy link
Contributor

SimonBoothroyd commented Feb 5, 2020

Could this play some role in the future of property evaluator, allowing us to standardize the way we implement plugins to provide other small molecule force field types?

I would love for this to play a role (i.e replace the majority of the custom FF assignment code in PE) - it looks like a much cleaner / extensible solution.

I'll circle back to this once the new OpenMM release drops (or please feel free to bump this if I don't action it).

@SimonBoothroyd SimonBoothroyd added the enhancement New feature or request label Feb 5, 2020
@SimonBoothroyd SimonBoothroyd self-assigned this Feb 5, 2020
@mattwthompson
Copy link
Member

I think an updated interpretation of this feature request is "can we use things like EspalomaTemplateGenerator with Evaluator?"

To which I figure the answer is "probably" if this is of interest - is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants