Attempt to specify hostname causes the whole service to be lost

[adelton]

I try to configure a service in /etc/umdns/printer.json:

{
  "samsung-ipp": {
    "service": "_ipp._tcp.local",
    "instance": "Samsung @ host",
    "port": 631,
    "txt": [
      "pdl=application/pdf,application/postscript,image/jpeg,image/png,image/pwg-raster,image/urf"
    ]
  }
}

I debug by running avahi-browse _ipp._tcp on another machine in the network and I see my service shown.

Looking at 3b341f4 it should be possible to also specify a hostname in the JSON which would be great -- I would be able to statically define the service on my OpenWrt device even for other machines. However, when I add the hostname attribute and

/etc/init.d/umdns restart

suddenly avahi-browse shows removal of the service altogether.

[adelton]

I believe the problem is cause by a premature return at

mdnsd/service.c

Line 256 in 93458ac

return;

When if (_tb[SERVICE_HOSTNAME]) { sees that hostname attribute / field, shouldn't the code service_load_hostname() and continue with setting up the service data structure?

[adelton]

For the record, I'm testing this with umdns - 2024.09.17~fbaca4b6-r1 on OpenWrt 24.10.0-rc5 (r28304-6dacba30a7).