Correct procedure to request a flag for a formula #25
Replies: 3 comments
-
If you're convinced that this is the Right Thing to do for all Homebrew Terraform users, submit a PR to change it: https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request |
Beta Was this translation helpful? Give feedback.
-
Making a pull request is the right way to request changes in homebrew. There's not going to be an option to have it both ways though, Homebrew core prohibits the use of install flags in formula. |
Beta Was this translation helpful? Give feedback.
-
Thanks for your input, I'm hesitant to change the value outright because it's not clear why it was added in the first place, Chesterton's fence and all, that's why I considered a flag to be solid middle ground. Since that isn't an option apparently, I'll try to figure out if there's any limitations to having it enabled. Currently it seems building etc works fine, but there may be more to it. |
Beta Was this translation helpful? Give feedback.
-
The formula for Terraform includes a hardcoded build-time env variable that disables using the cgo resolver:
The variable was introduced in this commit which sadly doesn't document why this change was made.
Using the cgo resolver can be a necessity when using Terraform with Avahi for example.
Currently I've manually edited the formula on my machine, but it would be nice to either revert this addition altogether or to add a flag so users can enable the resolver when installing the formula.
What's the correct procedure to file such a request?
Beta Was this translation helpful? Give feedback.
All reactions