Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note pitch and duration depends on sample rate #3

Open
shibe2 opened this issue Apr 17, 2023 · 1 comment
Open

Note pitch and duration depends on sample rate #3

shibe2 opened this issue Apr 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@shibe2
Copy link

shibe2 commented Apr 17, 2023

Describe the bug

It sounds bad at high sample rates.

To reproduce

linuxwave -r 192000 -c 2

Expected behavior

Pitches and durations should not depend on sample rate.

Software information

Arch Linux
linuxwave 0.1.0-1

@shibe2 shibe2 added the bug Something isn't working label Apr 17, 2023
@orhun
Copy link
Owner

orhun commented Apr 17, 2023

I'm not sure why this happens, needs a bit of investigation.

bors bot added a commit that referenced this issue Apr 17, 2023
7: docs(preset): add the "spooky_manor" preset r=orhun a=tranzystorek-io

<!--- Thank you for contributing to linuxwave! 🐧🎵-->

## Description

<!--- Describe your changes in detail -->

Adds the somewhat spooky and unpolished preset I've taken a liking to.

I only hope this isn't just some quirky side-effect of #3.

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots / Logs (if applicable)

## Types of Changes

<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] Documentation (no code change)
- [ ] Refactor (refactoring production code)
- [ ] Other <!--- (provide information) -->

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->

- [ ] My code follows the code style of this project.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.


Co-authored-by: Marcin Puc <[email protected]>
@orhun orhun removed their assignment Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants