invalid php generated

[cabbey]

I'm not going to claim the source PHP the tool was asked to deal with was good. Far from it, it was horrible. But the tool's output was worse in so far as it was invalid php.

Input: ($arr[$opt] ? '1' : null) ?: '0'
Output: ($arr[$opt] ? '1' : null ?? '0'

The context around it: that line is an argument to a function being called.... something like this:

<?php

class test {
    function weird(string $variable) {
        $array = [
            'a' => 'apple',
            'b' => 'bananana',
        ];
     
        $this->target(
            'Alpha',
            'Bravo',
            ($array[$variable] ? 'Charlie' : null) ?: 'Delta'
        );
            
    }

    function target(string $one, string $two, string $three) {
        echo "$one $two $three" . PHP_EOL;
    }
}

$thing = new test();
$thing->weird('a');
$thing->weird('z');

(once the resulting php syntax error brought my attention to this bit of code, it was thoroughly re-written and no longer resembles... whatever you want to call the above. I'm filing this just in the hopes you can see an obvious fix and save others from bit of panic that sets in when a commit that was 100% automated tooling fails on a pre-commit hook as simple as a syntax check.)

[orklah]

Hey! Thanks for the feedback. Don't worry, no judgment there, the project for which I made this plugin initially was probably worse!

I'll try to take a look at it soon!