You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In his review of #150@supakeen suggested using url.URL for the url handling in APIURL and RawURL instead of fmt.Sprintf.
Initially I thought it was a good idea, but after converting weldr I realize that this would make things awkward. Passing in elements to use with url.JoinPath would be really awkward compared to string constants, and constructing query strings would be messy, requiring you to call a function instead of just slapping it on the end of the route.
The urls used are all internal constants, and the protocol and host are hard-coded to http and localhost so I'm not really sure what the benefit of using url.URL would be.
The text was updated successfully, but these errors were encountered:
In his review of #150 @supakeen suggested using url.URL for the url handling in APIURL and RawURL instead of fmt.Sprintf.
Initially I thought it was a good idea, but after converting weldr I realize that this would make things awkward. Passing in elements to use with url.JoinPath would be really awkward compared to string constants, and constructing query strings would be messy, requiring you to call a function instead of just slapping it on the end of the route.
The urls used are all internal constants, and the protocol and host are hard-coded to http and localhost so I'm not really sure what the benefit of using url.URL would be.
The text was updated successfully, but these errors were encountered: