Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do-release-tags fails if reference doesn't exist #3

Open
ajodock opened this issue Jan 9, 2017 · 0 comments
Open

do-release-tags fails if reference doesn't exist #3

ajodock opened this issue Jan 9, 2017 · 0 comments

Comments

@ajodock
Copy link
Contributor

ajodock commented Jan 9, 2017

In do-release-tags if the new reference doesn't exist the user gets a cryptic error.

Ref centos-atomic-host/7/x86_64/devel/alpha does not currently exist
Traceback (most recent call last):
  File "./do-release-tags.orig", line 82, in <module>
    _,promotedcommit = r.write_commit(newparent, '', body, promotedmetadict.end(), newcommitroot, None)
NameError: name 'newparent' is not defined

The first line tells the user what they need to know but the exception isn't very helpful. It would be nice if the script would exit before the exception, and if the user had the option to automatically create the reference.

Automatically creating the reference could be useful for build systems that would auto generate the YAML file which may dynamically create new references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant