New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drive name really required? #162

Open

kulmann opened this issue Jan 31, 2024 · 2 comments

Member

kulmann commented Jan 31, 2024 •

edited

Loading

The spec defines the name of a drive as required, see
https://github.com/owncloud/libre-graph-api/blob/18cc51ae24b30aa25c141cb4bf48d342f99c88fb/api/openapi-spec/v1.0.yaml#L3274C7-L3274C15

In order to patch a drive with

headers: {
  Restore: true
}

the corresponding PATCH request requires the drive name to be provided in the request body, which doesn't make sense for that particular request.

Can we make the name attribute of the drive optional, or does that lead to other issues?

The text was updated successfully, but these errors were encountered:

Member Author

kulmann commented Jan 31, 2024

If the name attribute wasn't required we could drop the as any in https://github.com/owncloud/web/blob/eb6d68a9f73d4a5431ab03124284fd63318fb856/packages/web-pkg/src/composables/actions/spaces/useSpaceActionsRestore.ts#L31

LisaHue commented Apr 10, 2024 •

edited

Loading

Do we have news here? Was this fixed? You closed my issue eventhough it does not seem solved #6279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment