Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aXe runner #88

Open
joeyciechanowicz opened this issue Jul 24, 2019 · 4 comments
Open

Add support for aXe runner #88

joeyciechanowicz opened this issue Jul 24, 2019 · 4 comments

Comments

@joeyciechanowicz
Copy link
Member

Pa11y (not currently published) now supports multiple test runners. We need to add the ability to select runners in the webservices.

Therse a couple of ways this could be done:

  • Specify a global runner(s) in the config
  • Specify the runner(s) for each site when it's added to the webservices
    • This would require additional work in the dashboard
@jsa34
Copy link
Contributor

jsa34 commented Oct 2, 2019

I would have thought allowing specifying the runner(s) would be preferable, but would take longer - it would allow separation if necessary for results, as well as setting a customisable model for if/when future runners may be added.

I guess we would also need to set/decide what to do about existing tests that have no runner specified - would they maintain HTMLCS as the default or default to HTMLCS and aXe?

Thinking about pa11y-dashboard, the latter may cause unintentional changes to comparing historical data if relying on the graph tracking, but defaulting to all available runners makes migrating jobs to run on all runners more straightforward as I guess most would want to run on all available runners.

Just my thoughts!

@TathagataRoy1278
Copy link

I cannot find the code where it specifies the runner parameter, could you please point it out? I ask because pa11y documentation states that runner parameter is needed, else it'll throw an error

@sangitamane
Copy link
Member

sangitamane commented Sep 24, 2021

Hello, the default runner is htmlcs . There are 2 built in htmlcs and axe which you can configure as per your choice as mentioned here . If you don't specify any the default will be used. If you configure any other runner(except these 2), then it will error.
Hope it helps!

@TathagataRoy1278
Copy link

TathagataRoy1278 commented Sep 24, 2021

@sangitamane Thank You! I checked it out. I was confused with the pa11y documentation, but now it's cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants