feat(rpc): implement Err()

[pancsta]

Remote Err() is simply a getter.

[sureshkrishnan-v]

Hi, I’d like to work on this issue as a first-time contributor—could you confirm if it’s available and share any guidelines?

[pancsta]

Hi, thanks for the interest. This still hasnt been implemented, here are the guidelines:

• in rpcnames.go, new server enum entry & String()
• in rpc.go, new response struct, like type RespErr struct {err error}
• in rpc_server.go, new remote method, like

func (s *Server) RemoteErr(
	_ *rpc2.Client, args *Empty, resp *RespErr,
) error {

• in rpc_worker.go, Err() should call callFailsafe
  • similar to Add(), but only return the result, without clock updates
  • Worker.err can now be removed
• in rpc_test.go, smth like this:

func TestErr(t *testing.T) {
	// config
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
	source := utils.NewRelsRpcWorker(t, nil)
	_, _, s, c := NewTest(t, ctx, source, nil, nil, nil, false)

	// test
	source.AddErr(errors.New("test"))

	// assert
	
	// c.Worker.Err()
	// c.Worker.IsErr()
}

Feel free to ask questions. It will be interesting to see if errors.Is() will work out of the box...

[sureshkrishnan-v]

ok thank you i will work on this