Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge SignedTransactionIntoRecoveredExt and SignedTransaction #14615

Open
klkvr opened this issue Feb 20, 2025 · 1 comment · May be fixed by #14622
Open

Merge SignedTransactionIntoRecoveredExt and SignedTransaction #14615

klkvr opened this issue Feb 20, 2025 · 1 comment · May be fixed by #14622
Assignees
@lean-apple
Labels
A-sdk Related to reth's use as a library C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started

Comments

@klkvr
Copy link
Member

klkvr commented Feb 20, 2025

Describe the feature

SignedTransactionIntoRecoveredExt was initially added separately because it relied on types from reth-primitives crate which is no longer the case.

reth/crates/primitives-traits/src/transaction/signed.rs

Line 187 in 2a8f5b8

pub trait SignedTransactionIntoRecoveredExt: SignedTransaction {

Methods from SignedTransactionIntoRecoveredExt can now be moved to SignedTransaction and the trait itself can be removed

Additional context

No response
@klkvr klkvr added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Feb 20, 2025
@lean-apple
Copy link
Contributor

Hello, can I work on it ?

@lean-apple lean-apple linked a pull request Feb 20, 2025 that will close this issue
Open
@emhane emhane added C-debt A clean up/refactor of existing code A-sdk Related to reth's use as a library and removed C-enhancement New feature or request labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lean-apple lean-apple

Labels
A-sdk Related to reth's use as a library C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: merge signed tx traits lean-apple/reth
3 participants
@emhane @klkvr @lean-apple