Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Other variant to eth protocolmessage #14656

Open
mattsse opened this issue Feb 22, 2025 · 1 comment · May be fixed by #14660
Open

Add Other variant to eth protocolmessage #14656

mattsse opened this issue Feb 22, 2025 · 1 comment · May be fixed by #14660
Assignees
Labels
A-networking Related to networking in general C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 22, 2025

Describe the feature

it might be useful to extend the eth protocol message space on p2p, which currently isn't supported.

we can add support for this, but treat any unknown variant as a protocol error.

to do this we need to do some changes

  1. add an Other(u8) variant to
    pub enum EthMessageID {
  2. add an Other(Bytes) to

pub enum EthMessage<N: NetworkPrimitives = EthNetworkPrimitives> {

update the decoding functions

and then treat any EthMessage::Other as a protocol violation for now

EthMessage::Receipts(resp) => {
on_response!(resp, GetReceipts)
}

which should emit an disconnect error

cc @hai-rise

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 22, 2025
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-networking Related to networking in general and removed S-needs-triage This issue needs to be labelled labels Feb 22, 2025
@stfnberat
Copy link

@mattsse can I do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants