Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens to the sync job when peeringdb.com updates their schema? #107

Open
positron opened this issue Feb 13, 2025 · 0 comments
Open
Assignees
Milestone

Comments

@positron
Copy link

Could it cause data corruption if the main peeringdb API releases an update and I do not upgrade my client?

I see this code in the fetcher that should detect a version mismatch:

if re.search("client version is incompatible", error):
raise CompatibilityError(error)
raise ValueError(f"Bad request error: {error}")

However, it looks like the peeringdb API is parsing that client version from the http request's user agent, and I do not see any code in this repo setting the user agent.

https://github.com/peeringdb/peeringdb/blob/f6b68743229379608034d350c914a96dc2906dc0/src/peeringdb_server/rest.py#L269-L282

@leovegoda leovegoda self-assigned this Feb 13, 2025
@leovegoda leovegoda added this to the 1 Decide milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants