Add option for club applications to require graduation year

[julianweng]

Currently, as Penn Clubs does not require users to self-identify their graduation year, many club applications collect the information either through a separate question on the application or elsewhere in the process. This would add the option for clubs to mandate that people fill out their school year on the Penn Clubs platform before being able to submit their application.

This would benefit clubs, as there are less points for error (e.g. clubs forgetting to update their grad year question for new years) and reduces work for them. This would also benefit Clubs (and other clubs) as more users would be nudged to fill out their school year and increasing data availability for other applications.

There could be edge privacy cases where users would not want to expose their graduation year to other clubs or via their profile, but the former would seem rare (and impossible in practice for any club that would care about grad year) and the latter can be solved through hiding their profile. Open to discussion on this point, however.

[aviupadhyayula]

@julianweng I'm thinking about this more -- is there a reason we can't just mandate this (e.g. if you want to submit an application, you need to fill out the major & grad year fields on your profile page). If we make an opt-in kind of thing, I suspect that most club leaders won't discover it (since a lot of them just duplicate past applications). I also think it's reasonable to require these -- club leaders obviously benefit, and the knowledge is public anyway (you can just look someone up in the directory).

I'm envisioning a serializer-level change to the application submission flow, where we check if the user has set their grad year, major, and school. If they haven't, we throw a validation error.

[julianweng]

I think directory is technically voluntary (forget if it's opt-in or opt-out): this reasoning makes sense and I wouldn't be opposed to it but we should probably double-check with stakeholders before going down this path just in case.

I was thinking that we would run a one-time script that would scan current-cycle (Spring) applications and toggle the option on if certain keywords are found in the associated questions and question options (e.g. "Freshman", "2026", "graduation year", "class"), but there is the edge case where clubs might still care about grad year but ask it later on in their application process (off-platform).

[aviupadhyayula]

How about we just implement it as "always-on" in the backend for now (e.g. we require the info to be set before the application submission is created)? And we can check in with club leaders and OSA at our next meeting. (This'll let @yuviji get started.) I suspect that moving it from always-on to toggle-able won't be a substantial amount of work.