Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on overwriting? #4

Open
unhammer opened this issue Jun 14, 2019 · 3 comments
Open

Warn on overwriting? #4

unhammer opened this issue Jun 14, 2019 · 3 comments

Comments

@unhammer
Copy link

It'd be nice if this could warn before overwriting existing files.

@per1234
Copy link
Owner

per1234 commented Jun 15, 2019

Thanks for the suggestion @unhammer. I agree that is an important thing.

I'd welcome a PR for this. Otherwise I'll try to figure out how to do it when I get some free time to work on this project.

@unhammer
Copy link
Author

unhammer commented Jun 15, 2019

I actually did this in my fork ( unhammer@010682b ), but I ended up changing the code style quite a bit (my laptop has a short monitor and I prefer seeing full functions in one screenful =P). I also swapped default to JPG 1600x1600, but if you want I can make a PR with your defaults?

(Also, would be nice if GIMP could remember the last used settings, other filters do this so should be possible?)

@per1234
Copy link
Owner

per1234 commented Jun 15, 2019

I'd be receptive to an improvement in the code style if it's in a separate, dedicated commit that doesn't make any functional changes.


EDIT: saving the unhammer/batch-smart-resize@010682b patch here to make sure it won't get lost:
010682b6c41fe86a95058120d412b891f6f09f0a.patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants