Module :: Reggie Service Implementation - Findbugs fixes

[pfirmstone]

--   |   |   |   |   |   |   |   |   |   |

Classes	Bugs	Errors	Missing Classes
50	7	0	0

  |

  |

Files

  |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |

Class	Bugs
com.sun.jini.reggie.TransientRegistrarImpl	1
org.apache.river.reggie.RegistrarImpl	1
org.apache.river.reggie.RegistrarImpl$AddressTask	1
org.apache.river.reggie.RegistrarImpl$EventTask	2
org.apache.river.reggie.RegistrarImpl$Initializer	1
org.apache.river.reggie.RegistrarImpl$SvcReg	1

  |

  |

com.sun.jini.reggie.TransientRegistrarImpl

  |   |   |   |   |   |   |   |   |   |   |   |   |

Bug	Category	Details	Line	Priority
The class name com.sun.jini.reggie.TransientRegistrarImpl shadows the simple name of the superclass org.apache.river.reggie.TransientRegistrarImpl	BAD_PRACTICE	NM_SAME_SIMPLE_NAME_AS_SUPERCLASS	44-61	High

  |

  |

org.apache.river.reggie.RegistrarImpl

  |   |   |   |   |   |   |   |   |   |   |   |   |

Bug	Category	Details	Line	Priority
Exceptional return value of java.util.concurrent.ExecutorService.submit(Callable) ignored in org.apache.river.reggie.RegistrarImpl.pendingEvent(RegistrarImpl$EventReg, ServiceID, Item, int, long)	BAD_PRACTICE	RV_RETURN_VALUE_IGNORED_BAD_PRACTICE	6150	Medium

  |

  |

org.apache.river.reggie.RegistrarImpl$AddressTask

  |   |   |   |   |   |   |   |   |   |   |   |   |

Bug	Category	Details	Line	Priority
Redundant nullcheck of addr, which is known to be non-null in org.apache.river.reggie.RegistrarImpl$AddressTask.run()	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	2405	Medium

  |

  |

org.apache.river.reggie.RegistrarImpl$EventTask

  |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |

Bug	Category	Details	Line	Priority
org.apache.river.reggie.RegistrarImpl$EventTask defines compareTo(RegistrarImpl$EventTask) and uses Object.equals()	BAD_PRACTICE	EQ_COMPARETO_USE_OBJECT_EQUALS	2266-2270	Medium
Switch statement found in org.apache.river.reggie.RegistrarImpl$EventTask.call() where default case is missing	STYLE	SF_SWITCH_NO_DEFAULT	2226-2247	Medium

  |

  |

org.apache.river.reggie.RegistrarImpl$Initializer

  |   |   |   |   |   |   |   |   |   |   |   |   |

Bug	Category	Details	Line	Priority
Unused field: org.apache.river.reggie.RegistrarImpl$Initializer.httpsDiscovery	PERFORMANCE	UUF_UNUSED_FIELD	Not available	Medium

  |

  |

org.apache.river.reggie.RegistrarImpl$SvcReg

  |   |   |   |   |   |   |   |   |   |   |   |   |

Bug	Category	Details	Line	Priority
org.apache.river.reggie.RegistrarImpl$SvcReg defines compareTo(Object) and uses Object.equals()	BAD_PRACTICE	EQ_COMPARETO_USE_OBJECT_EQUALS	710-722	Medium