New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(C++) 1-based index #24

Open

mitjap opened this issue Mar 3, 2022 · 0 comments

Contributor

mitjap commented Mar 3, 2022

I've noticed that in some places you used 1-based indices. I guess all of this should be 0-based?

simpleICP/c++/src/simpleicp.cpp

Line 164 in 1478851

for (int i = 1; i < v.size(); i++)

simpleICP/c++/src/simpleicp.cpp

Line 181 in 1478851

for (int i = 1; i < v.size(); i++)

simpleICP/c++/src/pointcloud.cpp

Line 82 in 1478851

for (long i = 1; i < NoPts(); i++)

mitjap changed the title ~~1-based index~~ (C++) 1-based index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment