Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making pynch into a package #4

Open
e-eight opened this issue Dec 4, 2024 · 1 comment
Open

Making pynch into a package #4

e-eight opened this issue Dec 4, 2024 · 1 comment

Comments

@e-eight
Copy link

e-eight commented Dec 4, 2024

I think this is a very useful project. Particularly in my case, I am using this as a dependency for other projects that use the AME/NUBASE data. It is much easier to use as a dependency if it can be installed as a package with pip.

I made a fork and made some modifications so that it can be packaged. The main modifications:

  1. Moved all the code to src: src/pynch, src/app.py
  2. Moved the data to src/pynch/data
  3. Replaced the hard links to the data with importlib.resources
  4. Renamed Nubase to NUBASE to match AME

You can take a look at my fork here: https://github.com/e-eight/pynch/. You can install it with pip install git+https://github.com/e-eight/pynch.git.

If you are okay with the changes, I can create a PR for you to merge.

@php1ic
Copy link
Owner

php1ic commented Dec 6, 2024

Hi @e-eight,

I'm glad you find this project useful and thank you for the suggestion. I like the idea of creating an installable package so happy for you to create a PR from your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants