Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event: "whole day" and "open end" have no effect #3243

Open
tisto opened this issue Apr 11, 2022 · 5 comments · May be fixed by #6165
Open

Event: "whole day" and "open end" have no effect #3243

tisto opened this issue Apr 11, 2022 · 5 comments · May be fixed by #6165
Assignees

Comments

@tisto
Copy link
Member

tisto commented Apr 11, 2022

Describe the bug

In Plone Classic the UI for the start/end date adapts if the user checks the "whole day" checkbox (time fields disappear) and the "open end" checkbox (end date/time disappear). This is not the case in Volto and this confuses our editors.

Sprints-—-Plone-Enterprise-Level-CMS-Free-and-OpenSource-Community-Driven-Secure

Sprints-—-Plone-Enterprise-Level-CMS-Free-and-OpenSource-Community-Driven-Secure (1)

To Reproduce
Steps to reproduce the behavior:

  1. As admin
  2. Go to https://volto.kitconcept.dev
  3. Create a new event https://volto.kitconcept.dev/add?type=Event
  4. Click the "whole day" or "open end" checkbox in the right column
  5. Nothing changes in the UI

Expected behavior

  • When the user checks the "whole day" checkbox, the time fields dissapear
  • When the user checks the "open end" checkbox, the end date/time field dissapear

Screenshots

Add-Event (1)

Software (please complete the following information):

  • Plone Version 15.2.1
@tisto tisto added this to the Plone 6.0 milestone Apr 19, 2022
@ichim-david
Copy link
Member

Since the Events content type isn't blocks enabled it uses the form widgets from the default form construction.
The showing and hiding of the end and start date were hidden on toggle within Plone 5 with jQuery and not part of the Boolean or DateTime picker widgets.
https://github.com/plone/plone.app.event/blob/3.2.x/plone/app/event/browser/resources/event.js#L184
There is no such functionality within Volto's Checkbox field to my knowledge.
https://github.com/plone/plone.app.event/blob/master/plone/app/event/dx/behaviors.py#L129

@tisto
Copy link
Member Author

tisto commented May 5, 2022

@ichim-david we disabled those two fields in our project because they do not provide any functionality. If we can't come up with a solution, we should do the same (at least for now) in Volto. Then we have to live with the fact that we do not provide the functionality that Classic currently has.

@cekk
Copy link
Member

cekk commented Jul 14, 2022

@tisto any news with this issue or you still disable the fields?

@tisto
Copy link
Member Author

tisto commented Dec 2, 2022

@cekk those fields are still disabled. Unless someone picks this up and implements the full functionality, this is what we should do IMHO.

@stevepiercy
Copy link
Collaborator

I've included this in my draft PLIP for event content types: plone/Products.CMFPlone#4115.

cihanandac added a commit to cihanandac/volto that referenced this issue Jul 12, 2024
This change enables "Whole Day checkbox to hide the time value of the "Event Starts"
and "Event Ends" fields. Fixes issue plone#3243
cihanandac added a commit to cihanandac/volto that referenced this issue Jul 12, 2024
This commit fixes the functionality of the "Open End" checkbox on Event forms. When enabled, the checkbox now correctly hides the "Event Ends" field, improving form usability. Fixes issue plone#3243
cihanandac added a commit to cihanandac/volto that referenced this issue Jul 12, 2024
This change enables "Whole Day checkbox to hide the time value of the "Event Starts"
and "Event Ends" fields. Fixes issue plone#3243
cihanandac added a commit to cihanandac/volto that referenced this issue Jul 12, 2024
This commit fixes the functionality of the "Open End" checkbox on Event forms. When enabled, the checkbox now correctly hides the "Event Ends" field, improving form usability. Fixes issue plone#3243
@stevepiercy stevepiercy moved this from Ready to In review in PLIP - plone.app.event based types Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: In review
5 participants