Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call_with_sigsetjmp should be toggleable via a feature flag #1

Open
pnkfelix opened this issue Aug 3, 2023 · 2 comments
Open

call_with_sigsetjmp should be toggleable via a feature flag #1

pnkfelix opened this issue Aug 3, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@pnkfelix
Copy link
Owner

pnkfelix commented Aug 3, 2023

I hadn't mean for call_with_sigsetjmp to be part of the default API for this crate. It just was something that seemed like some users would need and that would be "easy" to add (but maybe not as easy as you might think...)

@pnkfelix pnkfelix added the enhancement New feature or request label Aug 3, 2023
@jeff-davis
Copy link
Contributor

My use case needs call_with_sigsetjmp. Why is it important to have a feature flag here? I don't mind, but I also don't see the cost of leaving it there by default.

@pnkfelix
Copy link
Owner Author

pnkfelix commented Aug 10, 2023

I don't mind leaving it in as part of the default feature set.

I just imagine there may be some niche targets that have setjmp but not sigsetjmp; it seems trivial to make a flag to toggle the build to leave out sigsetjmp for that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants