Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed Subsurface Manual Shading Incorrect Implementation #1654

Open
JacksonJ-KC opened this issue Feb 19, 2025 · 0 comments · May be fixed by #1655
Open

Proposed Subsurface Manual Shading Incorrect Implementation #1654

JacksonJ-KC opened this issue Feb 19, 2025 · 0 comments · May be fixed by #1655

Comments

@JacksonJ-KC
Copy link
Collaborator

JacksonJ-KC commented Feb 19, 2025 •
edited
Loading

ruleset-checking-tool/rct229/rulesets/ashrae9012019/section5/section5rule23.py

Line 84 in 0039e66

else None,

proposed_subsurface_manual_shade is getting set to None if the subsurface has_manual_interior_shades is False. If Baseline and Proposed has_manual_interior_shades are both False then None is compared to False and FAIL outcome is received when it should be PASS
@JacksonJ-KC JacksonJ-KC linked a pull request Feb 19, 2025 that will close this issue
RCT/JDJ/5-23 logic correction #1655
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RCT/JDJ/5-23 logic correction pnnl/ruleset-checking-tool
1 participant
@JacksonJ-KC