Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise error for email from like "Name" address@domain #7

Open
tomlion opened this issue Apr 19, 2013 · 2 comments
Open

raise error for email from like "Name" address@domain #7

tomlion opened this issue Apr 19, 2013 · 2 comments

Comments

@tomlion
Copy link

tomlion commented Apr 19, 2013

submitted by hpyhacking, I copied from tomlion#11

mails_viewer (0.1.1)

below is mail sample

Date: Fri, 19 Apr 2013 14:29:19 +0800
from: "Name" [email protected]
To: [email protected]
Message-ID: <[email protected]>
Subject: Subject
Mime-Version: 1.0
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

I use below setting to my ActionMailer

default :from => "\"Name\" [email protected]"

This mail can show in Gamil, but mails_viewer raise error

undefined method join for "\"Name\" [email protected]":String

Screen Shot 2013-04-19 at 2 36 29 PM

@tomlion
Copy link
Author

tomlion commented Apr 19, 2013

@hpyhacking You can try to replace mail.from.join(', ') with Array.wrap(mail.from).join(', ') to fix this

@krisleech
Copy link

PR to fix this: #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants