Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: The Sidebar Button on the ribbon #243

Open
ExpertElite opened this issue Sep 17, 2024 · 3 comments
Open

BUG: The Sidebar Button on the ribbon #243

ExpertElite opened this issue Sep 17, 2024 · 3 comments
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@ExpertElite
Copy link

Primary Theme Version

v2.9.0

Debug Info

SYSTEM INFO:
Obsidian version: v1.6.7
Installer version: v1.6.5
Operating system: Windows 11 Home Single Language 10.0.22631
Login status: not logged in
Insider build toggle: off
Live preview: on
Base theme: light
Community theme: Primary v2.9.0
Snippets enabled: 6
Restricted mode: off
Plugins installed: 28
Plugins enabled: 18
1: Homepage v4.0.4
2: Various Complements v10.0.3
3: Numerals v1.5.0
4: Dataview v0.5.67
5: Kanban v2.0.51
6: Omnisearch v1.24.1
7: Templater v2.7.1
8: Obsidian Columns v1.5.2
9: Hider v1.5.1
10: Better footnote v1.0.1
11: Theme Picker v1.0.8
12: MySnippets v1.2.3
13: Advanced Canvas v3.1.0
14: Arcane Obfuscate v1.0.3
15: Dynamic Embed v1.1.0
16: Style Settings v1.0.9
17: Excalidraw v2.5.0
18: Outliner v4.8.1

Describe the enhancement

image

The Sidebar toggle button is coming on top of the uppermost option of the in the ribbon. It would be better if the button is placed here like this instead i guess.

image

(And P.S., your manifest.json file still says v2.8.0. when I checked, so might want to fix that for ease. ;) )

@ExpertElite ExpertElite added the 🧞‍♂️ enhancement Suggestion for visual improvements, and style settings customization label Sep 17, 2024
@ceciliamay
Copy link
Collaborator

oh thanks for reporting this! i'll have a look into it this week. sorry about the incompatibility! i don't have windows so i suppose i have to set up a vm. and re: the versioning - hahaha thanks for catching that!!

@ceciliamay ceciliamay added 🐛 bug Something isn't working and removed 🧞‍♂️ enhancement Suggestion for visual improvements, and style settings customization labels Sep 17, 2024
@ceciliamay ceciliamay self-assigned this Sep 17, 2024
@ceciliamay ceciliamay moved this to Todo in ⭕ All Tasks Sep 17, 2024
@ceciliamay
Copy link
Collaborator

ceciliamay commented Sep 25, 2024

looked into this today using my virtual machine. observations:

html element placement for the toggle is different in windows vs. macos/linux probably due to the exit-maximize-minimize buttons placed at the left in macos/linux vs. right side in windows.

in the html, the toggle is placed under the side-dock-ribbon in windows. the toggle is placed in the sidebar/editor in macos/linux. so moving the placement of the toggle might not be possible through css only.

i tried making the toggle be fixed and in place at the top left, but for some reason the collapse button isn't working if i do that.

i will just just fix the spacing issue and the button overlap.

@ceciliamay ceciliamay added this to the 2.12.0 milestone Sep 27, 2024
@AdamEternal
Copy link

AdamEternal commented Nov 27, 2024

I've been trying to get the sidebar toggle button to work while not overlapping a ribbon action button, but the sidebar button insists on overlapping with a ribbon button to work. I am so lost.

Quick edit: This is with the slideout ribbon style, per the topic. Thought I'd clarify anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants