Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› [BUG] - Update placeholder images in docs #910

Open
joshfarrant opened this issue Jan 28, 2025 · 0 comments
Open

πŸ› [BUG] - Update placeholder images in docs #910

joshfarrant opened this issue Jan 28, 2025 · 0 comments
Labels
brand bug Something isn't working

Comments

@joshfarrant
Copy link
Contributor

joshfarrant commented Jan 28, 2025

Describe the bug

The domain we were previously using for our placeholders β€” placeholder.com β€” has been sold and is no longer a placeholder image site. This has caused the images in our docs to 404.

We should find a replacement β€” remote or local β€” and update our images to use that replacement.

Note: we need to consider colour contrast when choosing a replacement placeholder image, see https://github.com/github/primer/issues/3737

Reproduction steps

  1. Go to https://primer.style/brand/components/Card/react#image
  2. Note the missing placeholder image

Expected behavior

  1. Go to https://primer.style/brand/components/Card/react#image
  2. A placeholder image is rendered

Screenshots

Image

Browsers

No response

OS

No response

@joshfarrant joshfarrant added bug Something isn't working brand labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant