Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Pillar Image added whitespace when as="picture" attribute is used. #911

Open
joshvogel17 opened this issue Jan 28, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@joshvogel17
Copy link

joshvogel17 commented Jan 28, 2025

Describe the bug

Found while working on: https://github.com/github/marketing-platform-services/issues/3793
Relevant PR: https://github.com/github/github/pull/359729

When adding a Pillar.Image and using the as="picture" the border on the bottom of the image was not rounded. Inspecting the page in the developers tools showed there to be some additional whitespace at the bottom of the image causing the issue. As a workaround, adding the style vertical-align: bottom to Pillar.Image seemed to resolve the issue.

Image where as="picture" property is set
Image

Image where default as property is set

Image

Reproduction steps

1. Create Pillar with Pillar.Image
2. Set `as="picture"` property to `Pillar.Image`
3. View Pillar. Notice that the border is not rounded on the bottom.

Expected behavior

Pillar.Image with as="picture" property set will still have a rounded border on the bottom.

Screenshots

Browsers

Chrome

OS

Mac

@joshvogel17 joshvogel17 added the bug Something isn't working label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant