Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG1 - TG8 Volume Bar graph from 0 - 14 #539

Open
Banana71 opened this issue Aug 15, 2023 · 7 comments
Open

TG1 - TG8 Volume Bar graph from 0 - 14 #539

Banana71 opened this issue Aug 15, 2023 · 7 comments

Comments

@Banana71
Copy link

Why do we have a bar graph for adjusting the volume?
Internally the miniDexed works with a resolution of 0 - 99 but we use a coarse resolution of 0 - 14 (scaled to 0 - 99). A finer adjustment via MIDI is possible with a controller keyboard, but then all TG's are adjusted on the same MIDI channel.
A finer resolution would be desirable, especially when using the miniDexed as a multitimbral module. It should be possible to change the volume parameter to 0-99.

What do you mean?

@probonopd
Copy link
Owner

probonopd commented Aug 15, 2023

I am using MiniDexed with just 4 buttons, no rotary encoder.

Do we really want to have to press the button 99 times?

@Banana71
Copy link
Author

Do we really want to have to press the button 99 times?

No, that's why I have an encoder :-)
But I think it's important to be able to adjust the parameters over the entire range.
With most electronic devices with switch operation, you would hold down the button and then parameters would be adjusted more quickly after a short time. e.g.

@probonopd
Copy link
Owner

Good idea.

@diyelectromusic
Copy link
Contributor

I think the volume is adjustable over the entire range - see https://github.com/probonopd/MiniDexed/blob/main/src/minidexed.cpp#L494

But just the display is quantised to blocks as the default display is "text only"... see https://github.com/probonopd/MiniDexed/blob/main/src/uimenu.cpp#L1006

Kevin

@probonopd
Copy link
Owner

That's actually how I hoped it would be :)

@diyelectromusic
Copy link
Contributor

But just the display is quantised to blocks as the default display is "text only"... see https://github.com/probonopd/MiniDexed/blob/main/src/uimenu.cpp#L1006

Ok, not quite - the UI does indeed update the volume in steps of 8 - it is the third parameter here:
https://github.com/probonopd/MiniDexed/blob/main/src/uimenu.cpp#L227

Kevin

@probonopd
Copy link
Owner

If we have full granularity via MIDI CC then I think it's fine as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants