Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on ingress.kubernetes.io/force-ssl-redirect is outdated #6769

Open
jwnx opened this issue Nov 19, 2024 · 2 comments
Open

Documentation on ingress.kubernetes.io/force-ssl-redirect is outdated #6769

jwnx opened this issue Nov 19, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jwnx
Copy link

jwnx commented Nov 19, 2024

What steps did you take and what happened:
Since #252, Contour leverages HttpsRedirect instead of RequireTls to enforce force-ssl-redirect. All documentation versions are affected.

What did you expect to happen:
The documentation would describe the correct behavior.

Anything else you would like to add:
The ingress.kubernetes.io/force-ssl-redirect annotation was introduced by #149 in Jan, 2018. Its documentation was first written in 9e166f3 on Fev 6th, 2018 and the #252 fix was merged on Feb 26th, 2018, but the documentation wasn't updated since then.

Environment:
N/A

@jwnx jwnx added kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Nov 19, 2024
Copy link

Hey @jwnx! Thanks for opening your first issue. We appreciate your contribution and welcome you to our community! We are glad to have you here and to have your input on Contour. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant