Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect line numbers for provider issues #117

Open
AndrolGenhald opened this issue Feb 11, 2022 · 1 comment
Open

Incorrect line numbers for provider issues #117

AndrolGenhald opened this issue Feb 11, 2022 · 1 comment

Comments

@AndrolGenhald
Copy link
Contributor

AndrolGenhald commented Feb 11, 2022

The provider docblock line is set here, but $line is actually the byte offset in the file, not the line number.

@Jean85
Copy link

Jean85 commented Mar 18, 2022

From what I can see with a rapid var_dump, $provider_docblock_location->raw_line_number contains already the correct line for the provider method; but there's no reference to include the (eventually present) method dockblock, which that call probably attempts to set.

I would simply suppress that call, since having a totally wrong line number is worst that having a preview of the code snippet without the docblock..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants