Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug --diff --diff-methods creates false-positives #51

Open
muglug opened this issue Feb 2, 2020 · 1 comment
Open

Debug --diff --diff-methods creates false-positives #51

muglug opened this issue Feb 2, 2020 · 1 comment

Comments

@muglug
Copy link
Member

muglug commented Feb 2, 2020

On Psalm latest

./psalm --clear-cache
git checkout b3f6b56
./psalm --threads=8 --diff --diff-methods --show-info=false
./psalm --threads=8 --diff --diff-methods --show-info=false
git checkout 6f6e265
./psalm --threads=8 --diff --diff-methods --show-info=false

Expected: No issues
Actual: A whole bunch of PossiblyUnusedMethod issues that would normally be covered by the PHPUnit plugin

This is probably a bug in Psalm, rather than the plugin, but storing here because it affects the plugin.

@ktomk
Copy link
Contributor

ktomk commented Aug 5, 2020

I've seen things not working well (e.g. missing negatives) when not invoking with --no-cache when changing php versions / configuration / setup / switching revisions and all the like. Just saying as from my current understanding each psalm invocation should be with --no-cache to eliminate (unwanted) side-effects, especially with bug/issue reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants