Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference to window breaks tests #97

Closed
jywarren opened this issue Apr 18, 2019 · 0 comments · May be fixed by #98
Closed

reference to window breaks tests #97

jywarren opened this issue Apr 18, 2019 · 0 comments · May be fixed by #98

Comments

@jywarren
Copy link
Member

This fixed iOS compatibility in #43 but breaks the tests, which is silly! Many thanks for the iOS fix; this should be easy to resolve:

webjack/src/webjack.js

Line 15 in 3498536

var AudioContext = window.AudioContext || window.webkitAudioContext;

Failing test: https://travis-ci.org/publiclab/webjack/jobs/521502504

https://github.com/publiclab/webjack/pull/91/files#r276480540 has some suggestions, including just removing window. from both references.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove window. jywarren/webjack
1 participant
@jywarren