diff --git a/app/Http/Controllers/User/LoginLinkController.php b/app/Http/Controllers/User/LoginLinkController.php index 1ce0b06..2130038 100644 --- a/app/Http/Controllers/User/LoginLinkController.php +++ b/app/Http/Controllers/User/LoginLinkController.php @@ -6,7 +6,6 @@ use App\Models\User; use App\Models\LoginLink; -use Illuminate\Support\Arr; use Illuminate\Support\Str; use Illuminate\Http\Request; use App\Http\Controllers\Controller; @@ -19,9 +18,11 @@ final class LoginLinkController extends Controller { - private const RATE_LIMIT_PREFIX = 'login-link:'; - private const RATE_LIMIT_ATTEMPTS = 1; - private const EXPIRATION_TIME = 15; + private const string RATE_LIMIT_PREFIX = 'login-link:'; + + private const int RATE_LIMIT_ATTEMPTS = 1; + + private const int EXPIRATION_TIME = 15; /** * Create a new magic link. diff --git a/app/Models/LoginLink.php b/app/Models/LoginLink.php index a850b22..0fabdd9 100644 --- a/app/Models/LoginLink.php +++ b/app/Models/LoginLink.php @@ -69,8 +69,6 @@ public function user(): BelongsTo /** * Get the prunable model query. * This will delete all magic links that were created more than a week ago. - * - * @return Builder */ public function prunable(): Builder { diff --git a/tests/Feature/Controllers/User/LoginLinkControllerTest.php b/tests/Feature/Controllers/User/LoginLinkControllerTest.php index 274a974..f9f0a24 100644 --- a/tests/Feature/Controllers/User/LoginLinkControllerTest.php +++ b/tests/Feature/Controllers/User/LoginLinkControllerTest.php @@ -5,20 +5,19 @@ use App\Models\User; use App\Models\LoginLink; use Illuminate\Support\Str; -use Illuminate\Support\Facades\URL; use App\Notifications\LoginLinkMail; use Illuminate\Support\Facades\RateLimiter; use Illuminate\Support\Facades\Notification; use App\Http\Controllers\User\LoginLinkController; use Illuminate\Routing\Middleware\ThrottleRequests; -use function Pest\Laravel\assertAuthenticatedAs; use function Pest\Laravel\get; use function Pest\Laravel\post; +use function Pest\Laravel\assertGuest; use function Pest\Laravel\assertDatabaseHas; use function Pest\Laravel\withoutMiddleware; use function Pest\Laravel\assertDatabaseCount; -use function Pest\Laravel\assertGuest; +use function Pest\Laravel\assertAuthenticatedAs; covers(LoginLinkController::class); @@ -87,9 +86,7 @@ it('authenticates user with valid token', function (): void { $user = User::factory()->create(); - Str::createRandomStringsUsing(function () { - return 'fake-random-string'; - }); + Str::createRandomStringsUsing(fn(): string => 'fake-random-string'); post(route('login-link.store'), [ 'email' => $user->email, ]);