Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily CI with unpinned deps #580

Open
alexmojaki opened this issue Nov 12, 2024 · 6 comments · Fixed by #583
Open

Daily CI with unpinned deps #580

alexmojaki opened this issue Nov 12, 2024 · 6 comments · Fixed by #583
Assignees
@Kludex @sydney-runkle
Labels
P1 High priority Testing

Comments

@alexmojaki
Copy link
Contributor

Following up on #576

At the bare minimum we need a job that runs daily with the latest versions of all dependencies so that we can detect breakages.

Previously regular CI ran with unpinned dependencies which forced us to fix the problem ASAP. That had downsides, but I want to keep the upsides. I want to have some kind of system so that when the job fails we treat it with similar urgency to before, so that new users aren't immediately faced with a critical error caused by an outstanding bug. Relevant developers should definitely get an email about the job failing, but that's not quite enough. I may miss the email in a sea of notifications, or I may think someone else will deal with it. For now let's just say that if any of us see that CI has failed we should open an urgent issue if there isn't one already, and check with the team what the plan is.
@alexmojaki alexmojaki added Testing P1 High priority labels Nov 12, 2024
@Kludex
Copy link
Member

Kludex commented Nov 12, 2024

We can also add a weekly dependabot job?

@Kludex
Copy link
Member

Kludex commented Nov 12, 2024

Daily also works (the previous PR is closed).

@alexmojaki
Copy link
Contributor Author

That also works, but I also want daily CI for other things like testing a wider variety of versions as in #507 without slowing down PRs.

@Kludex
Copy link
Member

Kludex commented Nov 12, 2024

I forgot that uv.lock doesn't seem supported by dependabot yet.

@sydney-runkle sydney-runkle mentioned this issue Nov 12, 2024
Merged
@alexmojaki
Copy link
Contributor Author

Reopening because based on https://github.com/orgs/community/discussions/25351 the current workflow will only send an email to a single person, which isn't loud enough.

@alexmojaki alexmojaki reopened this Nov 13, 2024
@alexmojaki
Copy link
Contributor Author

(I know there's a TODO in that file in the PR which is probably because of this, I hadn't noticed until merging)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kludex Kludex

@sydney-runkle sydney-runkle

Labels
P1 High priority Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Daily CI with unpinned deps pydantic/logfire
3 participants
@alexmojaki @Kludex @sydney-runkle