Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to securely store oauth #51

Open
Keramblock opened this issue Feb 8, 2022 · 2 comments
Open

Provide a way to securely store oauth #51

Keramblock opened this issue Feb 8, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Keramblock
Copy link

Keramblock commented Feb 8, 2022

изображение
mb I miss something, but right now we forced to use configmap provided by helm chart itself to store data we need to work with oauth. MB better to at least allow to provide it from secret outside of helm chart or by file specified in container, so we could mount them there.

@kolesnikovae
Copy link
Member

Thank you for reporting the issue @Keramblock! Indeed, we lack this option. What do you think about using env variables, instead of the ConfigMap, as per the suggestion - #41 (comment) (not implemented yet)?

MB better to at least allow to provide it from secret outside of helm chart or by file specified in container, so we could mount them there.

It definitely makes sense. We already have extraVolumeMounts but the container args are hardcoded - to be fixed as well.

@kolesnikovae kolesnikovae added enhancement New feature or request security labels Feb 9, 2022
@Keramblock
Copy link
Author

Keramblock commented Feb 15, 2022

env variables, instead of the ConfigMap,
Currently we using Hashicorp Vault to securely work with secrets in k8s, so we could create secret from it, or pass file to pod using annotations via injector. So env variables would be viable, if we could pass them from secret to pod, using something like .Values.additionalEnvs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants