Improve error message about missing websockets module
#528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A tiny fix to help copy&paste a pip command to install websockets. Thanks
rchl
reviewed
Feb 7, 2024
pylsp/python_lsp.py
Outdated
| @@ -109,7 +109,7 @@ def start_ws_lang_server(port, check_parent_process, handler_class): | |||
| import websockets | |||
| except ImportError as e: | |||
| raise ImportError( | |||
| "websocket modules missing. Please run pip install 'python-lsp-server[websockets]" | |||
| "websocket modules missing. Please run 'pip install python-lsp-server[websockets]'" | |||
There was a problem hiding this comment.
It's the python-lsp-server[websockets] part that needs quotes to work in a shell.
There was a problem hiding this comment.
Interesting, in my terminal it's not necessary, so I wanted to use quotes to mark a part to copy.
What about adding a colon and quotes as you suggest (it works for me):
websocket modules missing. Please run: pip install 'python-lsp-server[websockets]'
ccordoba12
changed the title
websockets module
ccordoba12
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny fix to help copy&paste a pip command to install websockets.
Thanks.