Internal: Consider refactoring towards 'FP' code, avoiding mutable state

[mrseanryan]

Consider refactoring towards 'FP' code, avoiding mutable state.

The code may be simpler if we refactor to use a more 'Functional Programming' style, where we avoid mutating structures. (this is something I've learned more about recently :) )

In general this could make the code a bit easier to reason about, since a function would not modify its parameters (no side-effects).

---

example: analyzer.ts: - expandExportFromStar:

---

BEFORE

const expandExportFromStar = (files: File[], exportMap: ExportMap): void

• takes 2 parameters
• makes modifications to the 2nd parameter.

---

AFTER

A more FP signature would be like:

const expandExportFromStar = (files: File[], exportMap: ExportMap): ExportMap

• takes 2 parameters.
• Does NOT make modifications - instead, it returns a new ExportMap

[mrseanryan]

Marking as 'help wanted' since I think it could take quite a few iterations, and I'm not sure how much time I have free, until the Summer.