Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MODS_TO_NEUTRALIZE ignored in Layer activated by Hold-Tap button #24123

Open
2 tasks
Ceffa93 opened this issue Jul 15, 2024 · 1 comment
Open
2 tasks

Comments

@Ceffa93
Copy link

Ceffa93 commented Jul 15, 2024

Describe the Bug

I have a mod-tap key in Layer 2:
MT(MOD_LGUI, KC_6)
Layer 2 is activated from a hold-tap button:
LT(MO(2), KC_ENT)

I have neutralized GUI, but with the above conditions a hold causes GUI action to trigger.
Note that if I replace the layer-activation button with a non-hold-tap one, neutralization works correctly:
MO(2)

Keyboard Used

splitkb/aurora/sweep/rev1

Link to product page (if applicable)

No response

Operating System

Windows 11

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

Flags in config.h:
#define QUICK_TAP_TERM 0
#define TAPPING_TERM 175
#define PERMISSIVE_HOLD
#define RETRO_TAPPING
#define RETRO_TAPPING_PER_KEY
#define MODS_TO_NEUTRALIZE { MOD_BIT(KC_LGUI), MOD_BIT(KC_LALT) }
#define DUMMY_MOD_NEUTRALIZER_KEYCODE KC_RIGHT_CTRL

@Ceffa93
Copy link
Author

Ceffa93 commented Jul 15, 2024

Locally I was able to dirty fix the issue by modifying quantun/action.c from:

if (retro_tapping_counter == 2) {
    neutralize_flashing_modifiers(get_mods());
}

to:

if (retro_tapping_counter == 2 || retro_tapping_counter == 3) {
    neutralize_flashing_modifiers(get_mods());
}

Hope this info helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant