Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derived datasets: Remove dummy scaling attributes from DerivedDataset class #82

Open
ploh opened this issue Jan 11, 2017 · 2 comments
Open

Comments

@ploh
Copy link

ploh commented Jan 11, 2017

Currently, the scaling attribute is defined with

attribute :scaling,      Preset::Scaling

in DerivedDataset. But since the Preset::Scaling has attributes has_energy, has_agriculture and has_industry which are not respected when set for a DerivedDataset#scaling, this is not ideal - also, it is unnecessary, since the DerivedDataset has all the attributes of a Dataset directly, among them a lot of has_... attributes (has_energy is missing in the attributes of Dataset. Maybe we should add that? @antw @ChaelKruip).

Solution:
The Preset::Scaling class should get a newly invented superclass Atlas::Scaling without the has_.... This superclass is then used for the DerivedDataset#scaling.

@ploh ploh added the bug label Jan 11, 2017
@ploh ploh assigned ploh and grdw Jan 11, 2017
@grdw grdw removed the bug label Feb 2, 2017
@ploh ploh assigned ChaelKruip and unassigned ploh Feb 4, 2017
@ChaelKruip
Copy link

@ploh why am I assigned for this ticket? I have no idea what to do with this...

Re-assigning @ploh

@ChaelKruip ChaelKruip assigned ploh and unassigned ChaelKruip Feb 6, 2017
@antw antw assigned antw and unassigned ploh Feb 6, 2017
@ploh
Copy link
Author

ploh commented Feb 6, 2017

@ChaelKruip Yes, sorry, I should have commented why I did that. This is, of course, not for you to implement, but for @grdw - who is also assigned. I assigned it to you as well because I thought you are probably the one to decide / prioritize when/if Gerard should do this.

@grdw grdw removed their assignment May 16, 2018
@antw antw removed their assignment Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants