Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't thaw lsp-mode from fork/1 #538

Open
RohanHart opened this issue Jun 19, 2024 · 2 comments
Open

can't thaw lsp-mode from fork/1 #538

RohanHart opened this issue Jun 19, 2024 · 2 comments

Comments

@RohanHart
Copy link

Running straight-thaw-versions fails on lsp-mode due to the change in 77f0521 as straight.el doesn't seem to be configured correctly when the fork/1 branch hasn't been fetched from the new remote. The *straight-process* buffers contains

$ git rev-parse --verify fork/1

fatal: Needed a single revision

Including the full remote name works, ie., git rev-parse --verify fork/fork/1

@raxod502
Copy link
Member

raxod502 commented Sep 1, 2024

Blah, well, that is a bug in straight.el IMO since it should be fetching automatically if it needs to normalize such a branch name. This used to work, maybe I broke it at some point.

@raxod502
Copy link
Member

raxod502 commented Sep 1, 2024

Oh........... it probably happens because of the collision between the branch name and the remote name, which causes ambiguity. Shame on me for picking a weird branch name I guess. Still a bug in straight.el not handling this case well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants