-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
index: show the actions to the right of the partial and add a division #461
Conversation
Because tailwind v4 just shipped, I'm going to hold off until this gem properly supports it, then we can make sure this PR is styled appropriately for v4. |
aebae24
to
ba62389
Compare
just rebased so it fixes the conflict |
Will take a look at this and your other style updates in the next day or so! Thanks for your patience. |
@flavorjones can i do something to help out with reviews? maybe merging all the open PRs (re styling) into a single one for easier review? |
I've just been under water the last few weeks. Will get to these today. |
no rush, i was just wondering if there was anything I could do to help out. didn't want to push, apologies if it felt that way! |
ba62389
to
dc8251d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a simplifying commit but otherwise this is great! Thank you!
<%%= render <%= singular_table_name %> %> | ||
<div class="space-x-2"> | ||
<%%= link_to "Show", <%= model_resource_name(singular_table_name) %>, class: "rounded-md px-3.5 py-2.5 bg-gray-100 hover:bg-gray-50 inline-block font-medium" %> | ||
<%%= link_to "Edit", edit_<%= singular_route_name %>_path(<%= singular_table_name %>), class: "rounded-md px-3.5 py-2.5 bg-gray-100 hover:bg-gray-50 inline-block font-medium" %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a commit simplifying this to use edit_helper
.
oh, great, thank you! :) |
between objects.
Currently, when your collection has many objects, and given the "show this xxx" button is grey, it's hard to distinguish when an object ends and another one begins.
This PR adds a subtle division between objects and wraps the partial in a flex item, moving the show button to the right hand side. Also, as suggested in #457 , I've added the edit and destroy buttons.