From 24d093203b692194cc290feec201109a9fcff63e Mon Sep 17 00:00:00 2001 From: Alexander Potapenko Date: Wed, 19 Feb 2025 10:56:19 +0100 Subject: [PATCH] pkg/rpcserver: improve the mismatching arches error message Dump the whole flatrpc.ConnectRequest to the logs, so that we can better understand the cause of #5805 --- pkg/rpcserver/rpcserver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/rpcserver/rpcserver.go b/pkg/rpcserver/rpcserver.go index bb9bbbd075ff..de664cb0b683 100644 --- a/pkg/rpcserver/rpcserver.go +++ b/pkg/rpcserver/rpcserver.go @@ -419,7 +419,7 @@ func (serv *server) connectionLoop(baseCtx context.Context, runner *Runner) erro func checkRevisions(a *flatrpc.ConnectRequest, target *prog.Target) error { if target.Arch != a.Arch { - return fmt.Errorf("mismatching manager/executor arches: %v vs %v", target.Arch, a.Arch) + return fmt.Errorf("mismatching manager/executor arches: %v vs %v (full request: `%#v`)", target.Arch, a.Arch, a) } if prog.GitRevision != a.GitRevision { return fmt.Errorf("mismatching manager/executor git revisions: %v vs %v",