Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support aliasing with dependency.yaml #18

Closed
aiyengar2 opened this issue Feb 11, 2021 · 1 comment · Fixed by #106 or dbw7/charts-build-scripts#1
Closed

Support aliasing with dependency.yaml #18

aiyengar2 opened this issue Feb 11, 2021 · 1 comment · Fixed by #106 or dbw7/charts-build-scripts#1
Assignees
@aiyengar2
Labels
team/area3

Comments

@aiyengar2
Copy link
Contributor

Currently, rancher-monitoring required us to repackage packages/pushprox for every single pushprox dependency (e.g. compare the currently released version in main vs the one that will be released in dev-v2.5).

Instead, we should be able to specify a dependency.yaml that takes in aliases that are written into the requirements.yaml so that we only need to have rancher-pushprox pulled in once and referred to several times, as we did before.
@aiyengar2 aiyengar2 self-assigned this Feb 11, 2021
@aiyengar2 aiyengar2 mentioned this issue Mar 30, 2021
Open
@aiyengar2 aiyengar2 added this to the 2.x milestone Jun 3, 2021
@mjura mjura removed this from the 2.x milestone Jun 3, 2021
@aiyengar2 aiyengar2 added this to the 0.4.x milestone Jan 28, 2022
@aiyengar2
Copy link
Contributor Author

Possibly blocked on, or should be resolved by, #68

hardys added a commit to hardys/charts-build-scripts that referenced this issue Jul 30, 2023
@hardys
Handle aliases in chart dependencies
935ad77 
It's valid to have multiple dependencies with alternate aliases which
currently are removed on chart generation.

One way to resolve this is just to operate directly on the dependencies
list instead of generating a map keyed by name, which is less efficient
but avoids the problem of removing valid dependencies that use aliases.

Fixes: rancher#18
@hardys hardys mentioned this issue Jul 30, 2023
Merged
@dbw7 dbw7 mentioned this issue Jul 31, 2023
Merged
hardys added a commit to hardys/charts-build-scripts that referenced this issue Aug 1, 2023
@hardys
Handle aliases in chart dependencies
edd61d3 
It's valid to have multiple dependencies with alternate aliases which
currently are removed on chart generation.

One way to resolve this is just to operate directly on the dependencies
list instead of generating a map keyed by name, which is less efficient
but avoids the problem of removing valid dependencies that use aliases.

Fixes: rancher#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiyengar2 aiyengar2

Labels
team/area3
Projects
None yet
Milestone
No milestone
4 participants
@mjura @deniseschannon @aiyengar2 @Jono-SUSE-Rancher