Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different types of diffs for the generated-changes/patches directory #9

Open
aiyengar2 opened this issue Jan 29, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request team/mapps

Comments

@aiyengar2
Copy link
Contributor

Add a field to the package.yaml to allow for different options for patches exported to generated-changes/patches/.

The default (as it is now) would be:

diffOptions:
  type: unified_diff

But we could potentially support other diff types.

Would predominantly just require us to make changes to diff/diff.go.

@aiyengar2 aiyengar2 added the enhancement New feature or request label Jan 29, 2021
@aiyengar2 aiyengar2 self-assigned this Jan 29, 2021
@aiyengar2
Copy link
Contributor Author

The purpose for this enhancement is to be able to provide an option to avoid the "diffs on diffs" issue we see when reviewing PRs to a charts repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request team/mapps
Projects
None yet
Development

No branches or pull requests

4 participants