Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated links in app-readme.md of rancher-logging chart #23

Open
adamkpickering opened this issue Feb 13, 2025 · 1 comment
Open

Fix outdated links in app-readme.md of rancher-logging chart #23

adamkpickering opened this issue Feb 13, 2025 · 1 comment
Assignees
@adamkpickering
Labels
team/observability&backup This tag is needed to get something to show up in O&B boards

Comments

@adamkpickering
Copy link
Contributor

adamkpickering commented Feb 13, 2025 •
edited
Loading

In the app-readme.md file of the rancher-logging chart, there are two links. Both are broken - they result in a 404. We should update app-readme.md so that users are not confused by this.

For an example, see https://github.com/rancher/charts/blob/dev-v2.10/packages/rancher-logging/generated-changes/overlay/app-readme.md.
@adamkpickering adamkpickering self-assigned this Feb 18, 2025
@adamkpickering adamkpickering added the team/observability&backup This tag is needed to get something to show up in O&B boards label Feb 18, 2025
@adamkpickering adamkpickering mentioned this issue Feb 18, 2025
Merged
@mallardduck mallardduck mentioned this issue Feb 19, 2025
Closed
@mallardduck
Copy link
Member

Here is the PR where we synced this fix into Rancher Charts: rancher/charts#5209

For testing QA should use: rancher-logging 106.0.0-rc.1+up4.10.0-rancher.1

This was referenced Feb 25, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamkpickering adamkpickering

Labels
team/observability&backup This tag is needed to get something to show up in O&B boards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mallardduck @adamkpickering