You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note how it only updates the KUSTOMIZE_VERSION line currently. It seems it has been broken for some time based on past PRs. And we have simply patched over them to fix, so that's why I patched it manually again this time. However 2.9/2.8 branches are frozen so those PRs have time to resolve this so I won't patch those manually (until I need to).
It seems that to fix this we would need Renovate to be able to apply changes sequentially. And then be able to act on updated values when processing later rules/managers. However from the best I can tell this isn't possible, it doesn't seem to be from some basic research in renovate rules.
We would want to have 1 rule that updates both the KUSTOMIZE_VERSION lines and all # renovate [..] digestVersion=kustomize/ lines to the same new version. Then subsequently the rule to process the hash values would need to be able to see that new version and fetch the digest for that.
The text was updated successfully, but these errors were encountered:
@mallardduck thanks for opening this issue. At first sight, this may be related to the versioning regex that is not being captured on the matchStrings. I will have to take a proper look at it to confirm though.
I was able to get it to update all the kustomize versions (even on renovate annotations). However I couldn't figure out how/if I could get Renovate to acknowledge those updated values when processing the rules to update the digest/hash.
In a recent set of PRs I realized that renovate isn't correctly updating all the values related to kustomize.
See here for a broken PR I manually fixed: rancher/shell#277
Here's the renovate commit: rancher/shell@cfb6caf
Note how it only updates the
KUSTOMIZE_VERSION
line currently. It seems it has been broken for some time based on past PRs. And we have simply patched over them to fix, so that's why I patched it manually again this time. However 2.9/2.8 branches are frozen so those PRs have time to resolve this so I won't patch those manually (until I need to).It seems that to fix this we would need Renovate to be able to apply changes sequentially. And then be able to act on updated values when processing later rules/managers. However from the best I can tell this isn't possible, it doesn't seem to be from some basic research in renovate rules.
Essentially what I mean is that given this block:
We would want to have 1 rule that updates both the
KUSTOMIZE_VERSION
lines and all# renovate [..] digestVersion=kustomize/
lines to the same new version. Then subsequently the rule to process the hash values would need to be able to see that new version and fetch the digest for that.The text was updated successfully, but these errors were encountered: