Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support / expose "labeled" filtered search #418

Open
bkarsin opened this issue Oct 19, 2024 · 3 comments
Open

[FEA] Support / expose "labeled" filtered search #418

bkarsin opened this issue Oct 19, 2024 · 3 comments
Labels
feature request New feature or request

Comments

@bkarsin
Copy link
Contributor

bkarsin commented Oct 19, 2024

Filtered search for a more general type of label data is needed for many use cases. Typically, this takes the form of a vector of integers for every vector in the dataset and query. The general predicate function approach implemented in search_with_filter can be used for this, but is not currently exposed in the header for CAGRA. As a work-around, the source file with "search_with_filtering" can be included directly, but this greatly increases compile time and is not ideal.

If it is simpler or more performant, another option is a less general "labeled" search option where a specific format of label data can be provided to perform filtered search this way. Something like this could satisfy most use cases and may be preferable to a completely general predicate function.

@bkarsin bkarsin added the feature request New feature or request label Oct 19, 2024
@lowener
Copy link
Contributor

lowener commented Oct 28, 2024

As of version 24.10, the search_with_filter function has been replaced with an overload on the search function that you can see here. The source file doesn't need to be included directly.

@bkarsin
Copy link
Contributor Author

bkarsin commented Oct 31, 2024

Does this new overloaded search function also work with an arbitrary predicate-based filter? I was under the impression the new overloaded version only supported bitset and bitmap filters.

@lowener
Copy link
Contributor

lowener commented Nov 6, 2024

It support only bitset or bitmap, depending on the index. Predicate-based filtering is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants